Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2989243002: Reject negative values for "b=AS". (Closed)

Created:
3 years, 4 months ago by Taylor Brandstetter
Modified:
3 years, 4 months ago
Reviewers:
Zhi Huang
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reject negative values for "b=AS". It doesn't make sense to have a negative RTP session bandwidth; RFC3550 doesn't define any meaning for this. So just treat it as invalid SDP. BUG=chromium:675361 Review-Url: https://codereview.webrtc.org/2989243002 Cr-Commit-Position: refs/heads/master@{#19221} Committed: https://chromium.googlesource.com/external/webrtc/+/bc88c6ba98806b629d64c832f8cebeafd75e93e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M webrtc/pc/webrtcsdp.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/pc/webrtcsdp_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
Zhi, can you take a look since Peter is gone?
3 years, 4 months ago (2017-08-02 00:32:17 UTC) #2
Zhi Huang
lgtm
3 years, 4 months ago (2017-08-02 00:42:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989243002/1
3 years, 4 months ago (2017-08-02 17:59:03 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 18:26:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bc88c6ba98806b629d64c832f...

Powered by Google App Engine
This is Rietveld 408576698