Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2989113002: Reland of Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on … (Closed)

Created:
3 years, 4 months ago by perkj_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on wt Added documentation of thread expectations for video tracks and sources to the API. Originally landed as patchset #2 id:20001 of https://codereview.webrtc.org/2964863002/. Patchset 1 is the originall cl. Patschet 2 is modified so that VideoTrackInterface::AddSink and RemoveSink have a default implementation. BUG=none Review-Url: https://codereview.webrtc.org/2989113002 Cr-Commit-Position: refs/heads/master@{#19195} Committed: https://chromium.googlesource.com/external/webrtc/+/773be36bd61d0c595790a00c8cfb0eab898798fd

Patch Set 1 #

Patch Set 2 : Readd default implementation of AddSink and RemoveSink. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -29 lines) Patch
M webrtc/api/mediastreaminterface.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/ortc/ortcfactory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/pc/mediastream_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/pc/rtpreceiver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/pc/rtpsenderreceiver_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/pc/statscollector_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/pc/trackmediainfomap_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/pc/videotrack.h View 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/pc/videotrack.cc View 5 chunks +16 lines, -13 lines 0 comments Download
M webrtc/pc/videotrack_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
perkj_webrtc
please
3 years, 4 months ago (2017-07-31 12:10:48 UTC) #7
Taylor Brandstetter
lgtm
3 years, 4 months ago (2017-07-31 17:19:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989113002/20001
3 years, 4 months ago (2017-08-01 06:19:36 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 06:22:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/773be36bd61d0c595790a00c8...

Powered by Google App Engine
This is Rietveld 408576698