Decoupling desktop_capture from Obj-C code.

The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (desktop_capture_objc and
desktop_capture_generic) and desktop_capture will act as a proxy between these
targets (this way we can avoid a circular dependency between
desktop_capture_generic and desktop_capture_objc).

BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/2989053002
Cr-Commit-Position: refs/heads/master@{#19607}
Committed: https://chromium.googlesource.com/external/webrtc/+/13b9882fd3999d8394126017042d62bae719180b

[mbonadei, 2017-08-11 12:15:32]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-08-14 04:36:26]

kjellander@webrtc.org changed reviewers:
+ sergeyu@chromium.org

[kjellander_webrtc, 2017-08-14 04:36:27]

adding sergeyu@ as well.

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
File webrtc/modules/desktop_capture/BUILD.gn (right):

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:170:
rtc_source_set("objc_desktop_capture") {
We seem to have a mix of prefixed objc_ targets and suffixed _objc targets in
the codebase. I prefer the latter, and it's what I've used for C-only targets in
the past. I think also _android and _linux suffixes already exists as well.
Please rename.

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:171: check_includes = false
Please include a comment referencing a bug tracking to get this fixed. OK to use
the umbrella bug if there isn't any specific one or webrtc:7743 is not suitable.

Is there a way to refactor out the cyclic dependency by moving
mac/desktop_configuration.h into it's own target?

[Sergey Ulanov, 2017-08-14 17:53:18]

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
File webrtc/modules/desktop_capture/BUILD.gn (right):

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:180: # deps = [ ":desktop_capture" ]
Remove this?

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:309: libs = [
maybe move this to objc_desktop_capture?

[mbonadei, 2017-08-15 14:55:40]

PTAL.

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
File webrtc/modules/desktop_capture/BUILD.gn (right):

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:170:
rtc_source_set("objc_desktop_capture") {
On 2017/08/14 04:36:26, kjellander_webrtc wrote:
> We seem to have a mix of prefixed objc_ targets and suffixed _objc targets in
> the codebase. I prefer the latter, and it's what I've used for C-only targets
in
> the past. I think also _android and _linux suffixes already exists as well.
> Please rename.

Done.

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:171: check_includes = false
On 2017/08/14 04:36:26, kjellander_webrtc wrote:
> Please include a comment referencing a bug tracking to get this fixed. OK to
use
> the umbrella bug if there isn't any specific one or webrtc:7743 is not
suitable.
> 
> Is there a way to refactor out the cyclic dependency by moving
> mac/desktop_configuration.h into it's own target?

In ps#2 we have removed the circular dependency.

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:180: # deps = [ ":desktop_capture" ]
On 2017/08/14 17:53:18, Sergey Ulanov wrote:
> Remove this?

Done.

https://codereview.webrtc.org/2989053002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:309: libs = [
On 2017/08/14 17:53:18, Sergey Ulanov wrote:
> maybe move this to objc_desktop_capture?

Done.

[mbonadei, 2017-08-15 15:02:32]

Description was changed from

==========
Decoupling desktop_capture from Obj-C code [with cyclic deps]

BUG=webrtc:7743
==========

to

==========
Decoupling desktop_capture from Obj-C code.

BUG=webrtc:7743
==========

[kjellander_webrtc, 2017-08-15 19:19:50]

lgtm

[mbonadei, 2017-08-16 14:21:00]

Description was changed from

==========
Decoupling desktop_capture from Obj-C code.

BUG=webrtc:7743
==========

to

==========
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (desktop_capture_objc and
desktop_capture_generic) and desktop_capture will act as a proxy between these
targets (this way we can avoid a circular dependency between
desktop_capture_generic and desktop_capture_objc).

BUG=webrtc:7743
==========

[mbonadei, 2017-08-30 13:40:04]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-08-30 13:40:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-30 14:24:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1504100404153750,
"parent_rev": "5d655cd898a8f0f2878d2080841e8af968e0d7f9", "commit_rev":
"13b9882fd3999d8394126017042d62bae719180b"}

[commit-bot: I haz the power, 2017-08-30 14:24:48]

Description was changed from

==========
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (desktop_capture_objc and
desktop_capture_generic) and desktop_capture will act as a proxy between these
targets (this way we can avoid a circular dependency between
desktop_capture_generic and desktop_capture_objc).

BUG=webrtc:7743
==========

to

==========
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (desktop_capture_objc and
desktop_capture_generic) and desktop_capture will act as a proxy between these
targets (this way we can avoid a circular dependency between
desktop_capture_generic and desktop_capture_objc).

BUG=webrtc:7743

Review-Url: https://codereview.webrtc.org/2989053002
Cr-Commit-Position: refs/heads/master@{#19607}
Committed:
https://chromium.googlesource.com/external/webrtc/+/13b9882fd3999d83941260170...
==========

[commit-bot: I haz the power, 2017-08-30 14:24:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/13b9882fd3999d83941260170...