Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2988553004: Adding Obj-C binding for RTCConfiguration::max_ipv6_networks. (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 4 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding Obj-C binding for RTCConfiguration::max_ipv6_networks. BUG=webrtc:7703 Review-Url: https://codereview.webrtc.org/2988553004 Cr-Commit-Position: refs/heads/master@{#19162} Committed: https://chromium.googlesource.com/external/webrtc/+/2059bb3e4bd8a7040705dd8d12815621bcd3c874

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCConfiguration.mm View 4 chunks +24 lines, -19 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Taylor Brandstetter
3 years, 5 months ago (2017-07-21 22:33:27 UTC) #3
Taylor Brandstetter
PTAL
3 years, 5 months ago (2017-07-21 22:34:31 UTC) #4
tkchin_webrtc
On 2017/07/21 22:34:31, Taylor Brandstetter wrote: > PTAL sorry was OOO R/F lgtm
3 years, 5 months ago (2017-07-25 22:56:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2988553004/20001
3 years, 4 months ago (2017-07-27 00:24:50 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 01:25:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2059bb3e4bd8a7040705dd8d1...

Powered by Google App Engine
This is Rietveld 408576698