webrtc/pc/remoteaudiosource.cc - Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/remoteaudiosource.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)

Patch Set: fix mistakes Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/remoteaudiosource.cc

diff --git a/webrtc/pc/remoteaudiosource.cc b/webrtc/pc/remoteaudiosource.cc

index 8d1a5d0fd4caa7072e9868264f56f08ae7c69d67..f6f23c3f24c19a0167a53186b07a8e67a27a0c76 100644

--- a/webrtc/pc/remoteaudiosource.cc

+++ b/webrtc/pc/remoteaudiosource.cc

@@ -96,7 +96,8 @@ bool RemoteAudioSource::remote() const {

}

void RemoteAudioSource::SetVolume(double volume) {

- RTC_DCHECK(volume >= 0 && volume <= 10);

+ RTC_DCHECK_GE(volume, 0);

+ RTC_DCHECK_LE(volume, 10);

for (auto* observer : audio_observers_)

observer->OnSetVolume(volume);

}

« no previous file with comments | « webrtc/pc/datachannel.cc ('k') | webrtc/pc/rtpreceiver.cc » ('j') | no next file with comments »