webrtc/modules/desktop_capture/win/dxgi_texture.cc - Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/win/dxgi_texture.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)

Patch Set: fix mistakes Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/desktop_capture/win/dxgi_texture.cc

diff --git a/webrtc/modules/desktop_capture/win/dxgi_texture.cc b/webrtc/modules/desktop_capture/win/dxgi_texture.cc

index 964e00f9c74ca28328fc622481c59818376b812d..f9cfd82ea1d9e4edd527a048b601b4e74c903db3 100644

--- a/webrtc/modules/desktop_capture/win/dxgi_texture.cc

+++ b/webrtc/modules/desktop_capture/win/dxgi_texture.cc

@@ -42,7 +42,8 @@ DxgiTexture::~DxgiTexture() = default;

bool DxgiTexture::CopyFrom(const DXGI_OUTDUPL_FRAME_INFO& frame_info,

IDXGIResource* resource) {

- RTC_DCHECK(resource && frame_info.AccumulatedFrames > 0);

+ RTC_DCHECK_GT(frame_info.AccumulatedFrames, 0);

+ RTC_DCHECK(resource);

ComPtr<ID3D11Texture2D> texture;

_com_error error = resource->QueryInterface(

__uuidof(ID3D11Texture2D),