Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: webrtc/rtc_base/opensslstreamadapter.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)
Patch Set: fix link failure Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/rtc_base/opensslstreamadapter.cc
diff --git a/webrtc/rtc_base/opensslstreamadapter.cc b/webrtc/rtc_base/opensslstreamadapter.cc
index 1c0b57894acd8de29a0bb5d9565ae079168053f6..4d9d533d4d61a8829cfdcc6936a0bdd150f3b13f 100644
--- a/webrtc/rtc_base/opensslstreamadapter.cc
+++ b/webrtc/rtc_base/opensslstreamadapter.cc
@@ -555,7 +555,8 @@ StreamResult OpenSSLStreamAdapter::Write(const void* data, size_t data_len,
switch (ssl_error) {
case SSL_ERROR_NONE:
LOG(LS_VERBOSE) << " -- success";
- RTC_DCHECK(0 < code && static_cast<unsigned>(code) <= data_len);
+ RTC_DCHECK_GE(code, 0);
mflodman 2017/08/09 15:27:07 RTC_DCHECK_GT
kwiberg-webrtc 2017/08/09 22:06:07 Done.
+ RTC_DCHECK_LE(code, data_len);
if (written)
*written = code;
return SR_SUCCESS;
@@ -619,7 +620,8 @@ StreamResult OpenSSLStreamAdapter::Read(void* data, size_t data_len,
switch (ssl_error) {
case SSL_ERROR_NONE:
LOG(LS_VERBOSE) << " -- success";
- RTC_DCHECK(0 < code && static_cast<unsigned>(code) <= data_len);
+ RTC_DCHECK_GT(code, 0);
+ RTC_DCHECK_LE(code, data_len);
if (read)
*read = code;

Powered by Google App Engine
This is Rietveld 408576698