Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)
Patch Set: fix link failure Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc
diff --git a/webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc b/webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc
index 48dc02748ba0bed42021106dd9b06c7ba747266e..f86e03ef31e4e93230d31b71cfacee3ba96b2b2f 100644
--- a/webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc
+++ b/webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc
@@ -87,7 +87,8 @@ void DxgiTextureStaging::AssertStageAndSurfaceAreSameObject() {
bool DxgiTextureStaging::CopyFromTexture(
const DXGI_OUTDUPL_FRAME_INFO& frame_info,
ID3D11Texture2D* texture) {
- RTC_DCHECK(texture && frame_info.AccumulatedFrames > 0);
+ RTC_DCHECK_GE(frame_info.AccumulatedFrames, 0);
mflodman 2017/08/09 15:27:07 Should be RTC_DCHECK_GT.
kwiberg-webrtc 2017/08/09 22:06:07 Done.
+ RTC_DCHECK(texture);
// AcquireNextFrame returns a CPU inaccessible IDXGIResource, so we need to
// copy it to a CPU accessible staging ID3D11Texture2D.

Powered by Google App Engine
This is Rietveld 408576698