Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2988143002: Remove NullReceiveStatistics (Closed)

Created:
3 years, 4 months ago by danilchap
Modified:
3 years, 4 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove NullReceiveStatistics rtcp_sender accepts nullptr as indication statistics shouldn't be used, Other uses of NullReceiveStatistcs were already deleted. BUG=webrtc:8016 Review-Url: https://codereview.webrtc.org/2988143002 Cr-Commit-Position: refs/heads/master@{#19197} Committed: https://chromium.googlesource.com/external/webrtc/+/8a1d2a315fb44a936cdf6eee646b7067e66ee8ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -43 lines) Patch
M webrtc/modules/rtp_rtcp/include/receive_statistics.h View 1 chunk +0 lines, -16 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
danilchap
3 years, 4 months ago (2017-07-31 16:32:37 UTC) #6
sprang_webrtc
lgtm
3 years, 4 months ago (2017-08-01 09:53:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2988143002/1
3 years, 4 months ago (2017-08-01 10:18:56 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 10:21:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8a1d2a315fb44a936cdf6eee6...

Powered by Google App Engine
This is Rietveld 408576698