Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as make public.

Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as make public.

BUG=None

Review-Url: https://codereview.webrtc.org/2987763003
Cr-Commit-Position: refs/heads/master@{#19149}
Committed: https://chromium.googlesource.com/external/webrtc/+/abbc430ea073b304f171821ad42c2b83eaf32c0b

[eladalon, 2017-07-25 13:35:51]

Description was changed from

==========
Get rid of unnecessary cast of webrtc::AudioSendStream to
webrtc::internal::AudioSendStream

BUG=None
==========

to

==========
Get rid of unnecessary cast of webrtc::AudioSendStream to
webrtc::internal::AudioSendStream

To avoid the cast, some functions are made virtual, and the destructor's access
is modified to public.

BUG=None
==========

[eladalon, 2017-07-25 13:35:51]

eladalon@webrtc.org changed reviewers:
+ danilchap@webrtc.org, nisse@webrtc.org, solenberg@webrtc.org,
stefan@webrtc.org

[eladalon, 2017-07-25 13:35:59]

PTAL

https://codereview.webrtc.org/2987763003/diff/1/webrtc/audio/audio_receive_st...
File webrtc/audio/audio_receive_stream.cc (right):

https://codereview.webrtc.org/2987763003/diff/1/webrtc/audio/audio_receive_st...
webrtc/audio/audio_receive_stream.cc:297:
voe_impl->GetChannelProxy(send_stream->GetConfig().voe_channel_id);
Some streams used config(), some GetConfig(). I'm taking this opportunity to
standardize all of them on one name.

https://codereview.webrtc.org/2987763003/diff/1/webrtc/audio/audio_send_stream.h
File webrtc/audio/audio_send_stream.h (right):

https://codereview.webrtc.org/2987763003/diff/1/webrtc/audio/audio_send_strea...
webrtc/audio/audio_send_stream.h:54: const webrtc::AudioSendStream::Config&
GetConfig() const override;
I'm not going to move this in the .cc file, though, to avoid messing git-blame
more than I have to. If anyone thinks we'd better move this there, too, I'm open
to that, though.

https://codereview.webrtc.org/2987763003/diff/1/webrtc/call/call.cc
File webrtc/call/call.cc (left):

https://codereview.webrtc.org/2987763003/diff/1/webrtc/call/call.cc#oldcode640
webrtc/call/call.cc:640: webrtc::internal::AudioSendStream* audio_send_stream =
This is the main motivation for this CL.

[eladalon, 2017-07-25 14:38:34]

Description was changed from

==========
Get rid of unnecessary cast of webrtc::AudioSendStream to
webrtc::internal::AudioSendStream

To avoid the cast, some functions are made virtual, and the destructor's access
is modified to public.

BUG=None
==========

to

==========
Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as
make public.

BUG=None
==========

[eladalon, 2017-07-25 14:39:17]

Changed things as per our discussion, Fredrick.

[danilchap, 2017-07-25 14:42:20]

lgtm with nit

https://codereview.webrtc.org/2987763003/diff/20001/webrtc/call/audio_send_st...
File webrtc/call/audio_send_stream.h (right):

https://codereview.webrtc.org/2987763003/diff/20001/webrtc/call/audio_send_st...
webrtc/call/audio_send_stream.h:34: virtual ~AudioSendStream() = default;
nit: put destructor after child types.

[eladalon, 2017-07-25 15:24:32]

The CQ bit was checked by eladalon@webrtc.org

[eladalon, 2017-07-25 15:24:32]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2987763003/#ps40001 (title:
".")

[commit-bot: I haz the power, 2017-07-25 15:24:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-25 15:31:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-25 15:31:12]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19594)

[the sun, 2017-07-25 21:26:49]

lgtm % nit

https://codereview.webrtc.org/2987763003/diff/1/webrtc/audio/audio_receive_st...
File webrtc/audio/audio_receive_stream.cc (right):

https://codereview.webrtc.org/2987763003/diff/1/webrtc/audio/audio_receive_st...
webrtc/audio/audio_receive_stream.cc:297:
voe_impl->GetChannelProxy(send_stream->GetConfig().voe_channel_id);
On 2017/07/25 13:35:59, eladalon wrote:
> Some streams used config(), some GetConfig(). I'm taking this opportunity to
> standardize all of them on one name.

Acknowledged.

https://codereview.webrtc.org/2987763003/diff/20001/webrtc/call/audio_send_st...
File webrtc/call/audio_send_stream.h (right):

https://codereview.webrtc.org/2987763003/diff/20001/webrtc/call/audio_send_st...
webrtc/call/audio_send_stream.h:152: virtual const
webrtc::AudioSendStream::Config& GetConfig() const = 0;
nit: try order methods the same in interface.h, impl.h and impl.cc

[eladalon, 2017-07-26 08:43:05]

https://codereview.webrtc.org/2987763003/diff/20001/webrtc/call/audio_send_st...
File webrtc/call/audio_send_stream.h (right):

https://codereview.webrtc.org/2987763003/diff/20001/webrtc/call/audio_send_st...
webrtc/call/audio_send_stream.h:34: virtual ~AudioSendStream() = default;
On 2017/07/25 14:42:20, danilchap wrote:
> nit: put destructor after child types.

Done.

https://codereview.webrtc.org/2987763003/diff/20001/webrtc/call/audio_send_st...
webrtc/call/audio_send_stream.h:152: virtual const
webrtc::AudioSendStream::Config& GetConfig() const = 0;
On 2017/07/25 21:26:49, the sun wrote:
> nit: try order methods the same in interface.h, impl.h and impl.cc

Done.

[eladalon, 2017-07-26 08:43:09]

The CQ bit was checked by eladalon@webrtc.org

[eladalon, 2017-07-26 08:43:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2987763003/#ps60001 (title:
"CR response")

[commit-bot: I haz the power, 2017-07-26 08:43:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-26 09:09:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1501058589787200,
"parent_rev": "22d162dc615c4d048b7075e5a3c5ec0372b06187", "commit_rev":
"abbc430ea073b304f171821ad42c2b83eaf32c0b"}

[commit-bot: I haz the power, 2017-07-26 09:09:53]

Description was changed from

==========
Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as
make public.

BUG=None
==========

to

==========
Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as
make public.

BUG=None

Review-Url: https://codereview.webrtc.org/2987763003
Cr-Commit-Position: refs/heads/master@{#19149}
Committed:
https://chromium.googlesource.com/external/webrtc/+/abbc430ea073b304f171821ad...
==========

[commit-bot: I haz the power, 2017-07-26 09:09:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/abbc430ea073b304f171821ad...