Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2987693002: Fix NSInteger formatting warning from clang 6 (Closed)

Created:
3 years, 5 months ago by oprypin_webrtc
Modified:
3 years, 5 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, mbonadei
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix NSInteger formatting warning from clang 6 "error: values of type 'NSInteger' should not be used as format arguments; add an explicit cast to 'long' instead" Casting to long is already a common practice in the code base. This has been blocking the Chromium roll which contains an update to clang 6.0.0 BUG=None Review-Url: https://codereview.webrtc.org/2987693002 Cr-Commit-Position: refs/heads/master@{#19127} Committed: https://chromium.googlesource.com/external/webrtc/+/d0727bfd4504e088851b4ef268f4f9cbd4df0015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
oprypin_webrtc
3 years, 5 months ago (2017-07-24 15:34:17 UTC) #5
magjed_webrtc
lgtm
3 years, 5 months ago (2017-07-25 07:42:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2987693002/1
3 years, 5 months ago (2017-07-25 07:42:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19562)
3 years, 5 months ago (2017-07-25 07:52:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2987693002/1
3 years, 5 months ago (2017-07-25 09:01:46 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 09:05:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d0727bfd4504e088851b4ef26...

Powered by Google App Engine
This is Rietveld 408576698