Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2987613002: Fix gae.py's detection of current active credentials. (Closed)

Created:
3 years, 5 months ago by Vadim Sh.
Modified:
3 years, 5 months ago
Reviewers:
nodir, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Fix gae.py's detection of current active credentials. There are two problems: 1. Looks like gcloud is not using ~/.config/cloud/credentials anymore. We now use public API to check for current active account instead. 2. Looks like appcfg.py is not aware of gcloud's credentials anymore, so we need to reintroduce appcfg-specific login command again. We call it appcfg_login. This will go away soon-ish once we switch to gcloud as the only supported mode of operation. R=nodir@chromium.org, maruel@chromium.org BUG=747588 Review-Url: https://codereview.chromium.org/2987613002 Committed: https://github.com/luci/luci-py/commit/8b90cdd97f8f088bcba2fa376ce49d9863b48902

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -8 lines) Patch
M appengine/components/tool_support/gae_sdk_utils.py View 3 chunks +42 lines, -8 lines 0 comments Download
M appengine/components/tools/gae.py View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Vadim Sh.
PTAL "hacks, hacks everywhere" http://3dn6i8277y3e2terx93zyfk5.wpengine.netdna-cdn.com/wp-content/uploads/2015/07/toy-story.png
3 years, 5 months ago (2017-07-21 23:32:40 UTC) #1
nodir
lgtm
3 years, 5 months ago (2017-07-21 23:39:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2987613002/20001
3 years, 5 months ago (2017-07-21 23:41:15 UTC) #4
commit-bot: I haz the power
3 years, 5 months ago (2017-07-21 23:45:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/8b90cdd97f8f088bcba2fa376ce49d9863b48902

Powered by Google App Engine
This is Rietveld 408576698