Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2987023003: Revert of Roll chromium_revision 7b48b3e487..d1978b0eb8 (489906:490413) (Closed)

Created:
3 years, 4 months ago by mbonadei
Modified:
3 years, 4 months ago
Reviewers:
buildbot
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Roll chromium_revision 7b48b3e487..d1978b0eb8 (489906:490413) (patchset #1 id:1 of https://codereview.webrtc.org/2991983002/ ) Reason for revert: A change in a GN template breaks a downstream project. I am working on it. Original issue's description: > Roll chromium_revision 7b48b3e487..d1978b0eb8 (489906:490413) > > Change log: https://chromium.googlesource.com/chromium/src/+log/7b48b3e487..d1978b0eb8 > Full diff: https://chromium.googlesource.com/chromium/src/+/7b48b3e487..d1978b0eb8 > > Changed dependencies: > * src/base: https://chromium.googlesource.com/chromium/src/base/+log/dc18085af9..0c5d2b7e91 > * src/build: https://chromium.googlesource.com/chromium/src/build/+log/c2f466d88c..c2a01ae6b8 > * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/a124f02721..a31287f953 > * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/7383cd5ee3..eba9a70810 > * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/74bda1ad73..687a602b61 > * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0f1f20d439..8b13c6e362 > * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/97ebed6795..a53b8db560 > * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/ba496e1820..d445995407 > DEPS diff: https://chromium.googlesource.com/chromium/src/+/7b48b3e487..d1978b0eb8/DEPS > > No update to Clang. > > TBR= > BUG=None > > Review-Url: https://codereview.webrtc.org/2991983002 > Cr-Commit-Position: refs/heads/master@{#19182} > Committed: https://chromium.googlesource.com/external/webrtc/+/9f0ef390f1d2126f2f35ce3ad75cac1d86b632bb TBR=buildbot@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2987023003 Cr-Commit-Position: refs/heads/master@{#19185} Committed: https://chromium.googlesource.com/external/webrtc/+/654c73ef909fedb89d05b942d37c285d23e8229b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M DEPS View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Revert of Roll chromium_revision 7b48b3e487..d1978b0eb8 (489906:490413)
3 years, 4 months ago (2017-07-28 19:25:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2987023003/1
3 years, 4 months ago (2017-07-28 19:25:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/654c73ef909fedb89d05b942d37c285d23e8229b
3 years, 4 months ago (2017-07-28 19:26:06 UTC) #6
mbonadei
3 years, 4 months ago (2017-07-31 11:07:46 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2986183002/ by mbonadei@webrtc.org.

The reason for reverting is: The downstream project has been fixed..

Powered by Google App Engine
This is Rietveld 408576698