Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issue 2987013002: Don't clear newer packets from the video_coding::PacketBuffer when calling ClearTo; (Closed)

Created:
3 years, 4 months ago by philipel
Modified:
3 years, 4 months ago
Reviewers:
terelius, sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't clear newer packets from the video_coding::PacketBuffer when calling ClearTo. BUG=webrtc:8060 Review-Url: https://codereview.webrtc.org/2987013002 Cr-Commit-Position: refs/heads/master@{#19212} Committed: https://chromium.googlesource.com/external/webrtc/+/c5fb4683e5841339ac1608be9dc853846038292a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M webrtc/modules/video_coding/packet_buffer.cc View 1 chunk +22 lines, -5 lines 2 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
philipel
3 years, 4 months ago (2017-07-28 15:23:54 UTC) #4
sprang_webrtc
Not that familiar with this code, but can rubber stamp if you need me to. ...
3 years, 4 months ago (2017-07-28 15:36:50 UTC) #5
philipel
https://codereview.webrtc.org/2987013002/diff/1/webrtc/modules/video_coding/packet_buffer.cc File webrtc/modules/video_coding/packet_buffer.cc (right): https://codereview.webrtc.org/2987013002/diff/1/webrtc/modules/video_coding/packet_buffer.cc#newcode134 webrtc/modules/video_coding/packet_buffer.cc:134: } On 2017/07/28 15:36:50, sprang_webrtc wrote: > Is this ...
3 years, 4 months ago (2017-08-01 11:22:03 UTC) #6
sprang_webrtc
lgtm
3 years, 4 months ago (2017-08-02 10:56:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2987013002/1
3 years, 4 months ago (2017-08-02 11:07:09 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 11:29:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c5fb4683e5841339ac1608be9...

Powered by Google App Engine
This is Rietveld 408576698