webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc - Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)

Patch Set: Remove static initialization from VideoContentType and remove memoization in AlrDetector Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

index 3bf85d57e13b8a928aa05c4b01b1fea1a7179f86..c544e77270576cc72da1c5a8626f17930599709a 100644

--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

@@ -926,8 +926,8 @@ int VP8EncoderImpl::GetEncodedPartitions(

input_image.render_time_ms();

encoded_images_[encoder_idx].rotation_ = input_image.rotation();

encoded_images_[encoder_idx].content_type_ =

- (codec_.mode == kScreensharing) ? VideoContentType::SCREENSHARE

- : VideoContentType::UNSPECIFIED;

+ (codec_.mode == kScreensharing) ? VideoContentType::Screenshare()

+ : VideoContentType::Unspecified();

encoded_images_[encoder_idx].timing_.flags = TimingFrameFlags::kInvalid;

int qp = -1;