webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc - Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)

Patch Set: Remove static initialization from VideoContentType and remove memoization in AlrDetector Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

index f5a19109844ad02a2df414713fe6a5e56626a639..a58080463749bd8604e88a94a57b0bbe735f99ed 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

+++ b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

@@ -368,8 +368,8 @@ int32_t H264EncoderImpl::Encode(const VideoFrame& input_frame,

encoded_image_.capture_time_ms_ = input_frame.render_time_ms();

encoded_image_.rotation_ = input_frame.rotation();

encoded_image_.content_type_ = (mode_ == kScreensharing)

- ? VideoContentType::SCREENSHARE

- : VideoContentType::UNSPECIFIED;

+ ? VideoContentType::Screenshare()

+ : VideoContentType::Unspecified();

encoded_image_.timing_.flags = TimingFrameFlags::kInvalid;

encoded_image_._frameType = ConvertToVideoFrameType(info.eFrameType);