Piggybacking simulcast id and ALR experiment id into video content type extension.

webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 213 matching lines @@
 //    0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
 //   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 //   |  ID   | len=0 | Content type  |
 //   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 constexpr RTPExtensionType VideoContentTypeExtension::kId;
 constexpr uint8_t VideoContentTypeExtension::kValueSizeBytes;
 constexpr const char* VideoContentTypeExtension::kUri;
 
 bool VideoContentTypeExtension::Parse(rtc::ArrayView<const uint8_t> data,
                                       VideoContentType* content_type) {
-  if (data.size() == 1 &&
-      data[0] < static_cast<uint8_t>(VideoContentType::TOTAL_CONTENT_TYPES)) {
-    *content_type = static_cast<VideoContentType>(data[0]);
+  if (data.size() == 1 && VideoContentType::IsValidContentType(data[0])) {

[sprang_webrtc, 2017/07/26 14:13:43]

Maybe be lenient when parsing? Mask out the lowest 6 bit which we know how to
deal with and warn that it contains unknown data.

[ilnik, 2017/07/26 14:49:48]

I think this static one-liner function will be optimized quite well.

+    *content_type = data[0];
     return true;
   }
   return false;
 }
 
 bool VideoContentTypeExtension::Write(uint8_t* data,
                                       VideoContentType content_type) {
   data[0] = static_cast<uint8_t>(content_type);
   return true;
 }
@@ skipping 127 matching lines @@
 
 size_t RepairedRtpStreamId::ValueSize(const std::string& rsid) {
   return RtpStreamId::ValueSize(rsid);
 }
 
 bool RepairedRtpStreamId::Write(uint8_t* data, const std::string& rsid) {
   return RtpStreamId::Write(data, rsid);
 }
 
 }  // namespace webrtc