Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 if (len != 0) { 450 if (len != 0) {
451 LOG(LS_WARNING) << "Incorrect video content type len: " << len; 451 LOG(LS_WARNING) << "Incorrect video content type len: " << len;
452 return; 452 return;
453 } 453 }
454 // 0 1 454 // 0 1
455 // 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 455 // 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
456 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 456 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
457 // | ID | len=0 | Content type | 457 // | ID | len=0 | Content type |
458 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 458 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
459 459
460 if (ptr[0] < 460 if (VideoContentType::IsValidContentType(ptr[0])) {
461 static_cast<uint8_t>(VideoContentType::TOTAL_CONTENT_TYPES)) {
462 header->extension.hasVideoContentType = true; 461 header->extension.hasVideoContentType = true;
463 header->extension.videoContentType = 462 header->extension.videoContentType = ptr[0];
464 static_cast<VideoContentType>(ptr[0]);
465 } 463 }
466 break; 464 break;
467 } 465 }
468 case kRtpExtensionVideoTiming: { 466 case kRtpExtensionVideoTiming: {
469 if (len != VideoTimingExtension::kValueSizeBytes - 1) { 467 if (len != VideoTimingExtension::kValueSizeBytes - 1) {
470 LOG(LS_WARNING) << "Incorrect video timing len: " << len; 468 LOG(LS_WARNING) << "Incorrect video timing len: " << len;
471 return; 469 return;
472 } 470 }
473 header->extension.has_video_timing = true; 471 header->extension.has_video_timing = true;
474 VideoTimingExtension::Parse(rtc::MakeArrayView(ptr, len + 1), 472 VideoTimingExtension::Parse(rtc::MakeArrayView(ptr, len + 1),
(...skipping 15 matching lines...) Expand all
490 return; 488 return;
491 } 489 }
492 } 490 }
493 } 491 }
494 ptr += (len + 1); 492 ptr += (len + 1);
495 } 493 }
496 } 494 }
497 495
498 } // namespace RtpUtility 496 } // namespace RtpUtility
499 } // namespace webrtc 497 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698