Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2986603002: Ignore NewApi Android Lint warning + Roll chromium_revision (Closed)

Created:
3 years, 5 months ago by ehmaldonado_webrtc
Modified:
3 years, 5 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ignore NewApi Android Lint warning + Roll chromium_revision Ignore NewApi and InlinedApi Android Lint warnings. They will be enabled once platform-tools is rolled. See crbug.com/739746. This is needed because of https://chromium.googlesource.com/chromium/src/build/+/6e3237729a9e02aef33705070fecc07b81dc3b86 Roll chromium_revision 1238950005..fd8f995919 (488218:488572) Change log: https://chromium.googlesource.com/chromium/src/+log/1238950005..fd8f995919 Full diff: https://chromium.googlesource.com/chromium/src/+/1238950005..fd8f995919 Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/9590d17c3d..ff92886fed * src/build: https://chromium.googlesource.com/chromium/src/build/+log/36a077c7b3..995d75919a * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/342e327240..d8aae3bcad * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/718dcd6f4b..639e83fbfc * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/8ac1939776..6fc19207c5 * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c7c5420fbc..e11a4d0d82 * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/d19b0ad9b2..97ebed6795 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/030de9aca2..50cda24eac DEPS diff: https://chromium.googlesource.com/chromium/src/+/1238950005..fd8f995919/DEPS No update to Clang. TBR= NOTRY=True BUG=None CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal Review-Url: https://codereview.webrtc.org/2986603002 Cr-Commit-Position: refs/heads/master@{#19119} Committed: https://chromium.googlesource.com/external/webrtc/+/fe43df155c20e3d01469476b3eadd8e030a9fa07

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revert InlinedApi suppression. #

Patch Set 3 : Update Chromium revision. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M DEPS View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M tools_webrtc/android/suppressions.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
ehmaldonado_webrtc
3 years, 5 months ago (2017-07-20 20:04:01 UTC) #2
sakal
https://codereview.webrtc.org/2986603002/diff/1/tools_webrtc/android/suppressions.xml File tools_webrtc/android/suppressions.xml (right): https://codereview.webrtc.org/2986603002/diff/1/tools_webrtc/android/suppressions.xml#newcode11 tools_webrtc/android/suppressions.xml:11: <issue id="InlinedApi" severity="ignore"/> This is not needed if we ...
3 years, 5 months ago (2017-07-21 09:27:04 UTC) #3
sakal
lgtm
3 years, 5 months ago (2017-07-24 09:00:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2986603002/40001
3 years, 5 months ago (2017-07-24 09:14:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_internal on master.internal.tryserver.corp.webrtc (JOB_FAILED, http://webrtc-buildbot-master.mtv.corp.google.com:21001/builders/linux_internal/builds/1534)
3 years, 5 months ago (2017-07-24 09:23:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2986603002/40001
3 years, 5 months ago (2017-07-24 09:48:49 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-24 09:52:04 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/fe43df155c20e3d01469476b3...

Powered by Google App Engine
This is Rietveld 408576698