Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2986363002: Mark ~DirectTransport with "override." (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Mark ~DirectTransport with "override." The destructor was not explicitly marked as "virtual" nor as "override". BUG=None Review-Url: https://codereview.webrtc.org/2986363002 Cr-Commit-Position: refs/heads/master@{#19236} Committed: https://chromium.googlesource.com/external/webrtc/+/8435e5518d4cd6eb8a08d44adb124aa839bc17a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/test/direct_transport.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
eladalon
PTAL
3 years, 4 months ago (2017-08-03 12:17:52 UTC) #2
stefan-webrtc
lgtm
3 years, 4 months ago (2017-08-03 13:27:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2986363002/1
3 years, 4 months ago (2017-08-03 13:56:57 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 14:44:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8435e5518d4cd6eb8a08d44ad...

Powered by Google App Engine
This is Rietveld 408576698