webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c - Issue 2986163002: Audit of kConstants missing the const qualifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)

Patch Set: rebase + constexpr Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c ('k') | webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c b/webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c

index f920dc2ef8b8e6717849096a309a793158c28427..b494cc287af40ee62e0433dea106b3a8a38cdaa0 100644

--- a/webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c

+++ b/webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c

@@ -42,7 +42,7 @@ static const uint16_t kOneBitEqualProbCdf[3] = {

0, 32768, 65535 };

/* Pointer to cdf array for encoder bandwidth (12 vs 16 kHz) indicator. */

-static const uint16_t* kOneBitEqualProbCdf_ptr[1] = {

+static const uint16_t* const kOneBitEqualProbCdf_ptr[1] = {

kOneBitEqualProbCdf };

@@ -1843,7 +1843,7 @@ static const uint16_t kBwCdf[25] = {

62804, 65535 };

/* pointer to cdf array for estimated bandwidth */

-static const uint16_t* kBwCdfPtr[1] = { kBwCdf };

+static const uint16_t* const kBwCdfPtr[1] = { kBwCdf };

/* initial cdf index for decoder of estimated bandwidth*/

static const uint16_t kBwInitIndex[1] = { 7 };