Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2986083002: Removed an obsolete DCHECK in AudioEncoderOpus. (Closed)

Created:
3 years, 4 months ago by tschumi
Modified:
3 years, 4 months ago
Reviewers:
tschumim, minyue-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed an obsolete DCHECK in AudioEncoderOpus. BUG=None Review-Url: https://codereview.webrtc.org/2986083002 Cr-Commit-Position: refs/heads/master@{#19177} Committed: https://chromium.googlesource.com/external/webrtc/+/54348fb5ce8ce606eb370cb7c4e36b7e3caec28e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tschumim
3 years, 4 months ago (2017-07-28 09:12:21 UTC) #4
minyue-webrtc
lgtm
3 years, 4 months ago (2017-07-28 09:13:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2986083002/1
3 years, 4 months ago (2017-07-28 09:14:09 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-07-28 09:53:08 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/54348fb5ce8ce606eb370cb7c...

Powered by Google App Engine
This is Rietveld 408576698