Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2986003002: Pin depot_tools version in DEPS to prevent breakages (Closed)

Created:
3 years, 4 months ago by oprypin_webrtc
Modified:
3 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Pin depot_tools version in DEPS to prevent breakages Incompatible upstream changes will be detected in Chromium roll instead of breaking presubmit find_depot_tools is already aware of this, see https://chromium.googlesource.com/chromium/src/+/cea92c51ac31ffeb3f7c36ade3d56b6fcaf593b5%5E%21 BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2986003002 Cr-Commit-Position: refs/heads/master@{#19165} Committed: https://chromium.googlesource.com/external/webrtc/+/40e7ebd426fd46b304fe22f52c6aa3091d4a8c08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M DEPS View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
oprypin_webrtc
3 years, 4 months ago (2017-07-27 08:02:08 UTC) #5
ehmaldonado_webrtc
On 2017/07/27 08:02:08, oprypin_webrtc wrote: How was this breaking before?
3 years, 4 months ago (2017-07-27 08:05:32 UTC) #6
oprypin_webrtc
On 2017/07/27 08:05:32, ehmaldonado_webrtc wrote: > On 2017/07/27 08:02:08, oprypin_webrtc wrote: > > How was ...
3 years, 4 months ago (2017-07-27 08:11:56 UTC) #7
ehmaldonado_webrtc
lgtm
3 years, 4 months ago (2017-07-27 08:36:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2986003002/1
3 years, 4 months ago (2017-07-27 08:37:16 UTC) #12
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 08:40:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/40e7ebd426fd46b304fe22f52...

Powered by Google App Engine
This is Rietveld 408576698