Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2985653003: Add "max_ipv6_networks" field to RTCConfiguration. (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 4 months ago
Reviewers:
Zhi Huang
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add "max_ipv6_networks" field to RTCConfiguration. This allows an application to easily override the default limit (currently 5). Also adding a test that covers more of the PeerConnection<->PortAllocator interaction. BUG=webrtc:7703 Review-Url: https://codereview.webrtc.org/2985653003 Cr-Commit-Position: refs/heads/master@{#19160} Committed: https://chromium.googlesource.com/external/webrtc/+/d21eab3eea96925c4e1fab25402b5f6dd16032bb

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1 line) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/pc/peerconnection.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 1 1 chunk +49 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Taylor Brandstetter
PTAL. I plan to do the Java/Obj-C API bindings in separate CLs.
3 years, 5 months ago (2017-07-21 19:55:00 UTC) #2
Zhi Huang
On 2017/07/21 19:55:00, Taylor Brandstetter wrote: > PTAL. I plan to do the Java/Obj-C API ...
3 years, 5 months ago (2017-07-21 20:15:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2985653003/20001
3 years, 4 months ago (2017-07-26 02:42:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/6369) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 4 months ago (2017-07-26 02:46:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2985653003/40001
3 years, 4 months ago (2017-07-26 23:11:36 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-07-26 23:50:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/d21eab3eea96925c4e1fab254...

Powered by Google App Engine
This is Rietveld 408576698