Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2985443002: Replace WEBRTC_TRACE logging in modules/audio_device/.. mac/ win/ (Closed)

Created:
3 years, 5 months ago by saza WebRTC
Modified:
3 years, 5 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace WEBRTC_TRACE logging in modules/audio_device/.. mac/ win/ Patch set 1: Run a script to replace occurrences of WEBRTC_TRACE logging with the new style, on webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc. Patch set 2: - Manually fix log lines not handled by the script - Adjust local macros that use WEBRTC_TRACE - Adjust some lines to conform with code style - Update the included headers - Remove the now unused object ID variables BUG=webrtc:5118 Review-Url: https://codereview.webrtc.org/2985443002 Cr-Commit-Position: refs/heads/master@{#19088} Committed: https://chromium.googlesource.com/external/webrtc/+/b4aa4eb06f745ea48ae891e8d1dd970beca500ba

Patch Set 1 : Run script. #

Patch Set 2 : Manual fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -684 lines) Patch
M webrtc/modules/audio_device/audio_device_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.h View 1 4 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.cc View 1 70 chunks +176 lines, -234 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_mixer_manager_mac.h View 1 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_mixer_manager_mac.cc View 1 47 chunks +106 lines, -138 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.h View 1 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.cc View 1 123 chunks +312 lines, -294 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
saza WebRTC
ptal!
3 years, 5 months ago (2017-07-19 08:04:19 UTC) #13
henrika_webrtc
Nice! lgtm
3 years, 5 months ago (2017-07-19 08:08:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2985443002/60001
3 years, 5 months ago (2017-07-19 08:09:54 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-19 08:12:44 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/b4aa4eb06f745ea48ae891e8d...

Powered by Google App Engine
This is Rietveld 408576698