Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2985413002: Don't use the Force(Demuxer), Luke. (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, danilchap
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't use the Force(Demuxer), Luke. Remove deprecated ctros of DirectTransport. BUG=None Review-Url: https://codereview.webrtc.org/2985413002 Cr-Commit-Position: refs/heads/master@{#19214} Committed: https://chromium.googlesource.com/external/webrtc/+/88df90b1fdbe667c76329030390844ccd9faa88f

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M webrtc/test/direct_transport.h View 1 1 chunk +1 line, -22 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
eladalon
Danil, this can't be landed yet, but I'm making sure you'd see this, which is ...
3 years, 4 months ago (2017-08-01 13:07:32 UTC) #2
eladalon
Done. Danil, could you PTAL?
3 years, 4 months ago (2017-08-01 15:49:24 UTC) #3
danilchap
Generally I see no problem with deleting deprecated code. This particular test class I'm not ...
3 years, 4 months ago (2017-08-01 16:15:21 UTC) #4
eladalon
Minyue, could you please have a look?
3 years, 4 months ago (2017-08-02 08:19:55 UTC) #6
stefan-webrtc
lgtm
3 years, 4 months ago (2017-08-02 08:23:32 UTC) #7
eladalon
Since this is a simple thing, and wouldn't land unless those functions aren't used, and ...
3 years, 4 months ago (2017-08-02 09:19:58 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2974453002 Patch 360001). Please resolve the dependency and ...
3 years, 4 months ago (2017-08-02 09:20:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2985413002/40001
3 years, 4 months ago (2017-08-02 12:39:51 UTC) #14
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 13:18:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/88df90b1fdbe667c763290303...

Powered by Google App Engine
This is Rietveld 408576698