Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2985133002: If adapter type is unknown and interface name is "ipsec", treat as VPN. (Closed)

Created:
3 years, 4 months ago by Taylor Brandstetter
Modified:
3 years, 4 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

If adapter type is unknown and interface name is "ipsec", treat as VPN. This will result in the ipsec interfaces being prioritized below Wi-Fi and cell interfaces. This makes the most difference when we hit the default limit for IPv6 interfaces (5), and there are lots of ipsec interfaces for whatever reason, resulting in the "real" interfaces that would actually succeed not being used. See the linked bug 7703. BUG=webrtc:7703, webrtc:3149 Review-Url: https://codereview.webrtc.org/2985133002 Cr-Commit-Position: refs/heads/master@{#19175} Committed: https://chromium.googlesource.com/external/webrtc/+/4cd599f02504e32224a688434db6d43f5c892167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M webrtc/rtc_base/network.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/rtc_base/network_unittest.cc View 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Taylor Brandstetter
PTAL. Besides adding an API to change the "5 IPv6 network" limit, this is an ...
3 years, 4 months ago (2017-07-26 22:36:53 UTC) #2
Taylor Brandstetter
Ping
3 years, 4 months ago (2017-07-27 17:49:00 UTC) #3
pthatcher1
lgtm
3 years, 4 months ago (2017-07-27 20:45:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2985133002/1
3 years, 4 months ago (2017-07-27 21:37:58 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 22:05:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4cd599f02504e32224a688434...

Powered by Google App Engine
This is Rietveld 408576698