Shrink critical-section scope in ReceiveStatisticsImpl::GetActiveStatisticians()

Shrink critical-section scope in ReceiveStatisticsImpl::GetActiveStatisticians()

The critical-section's scope can be shrunk (we can hold the lock for a shorter time).

BUG=None

Review-Url: https://codereview.webrtc.org/2984973002
Cr-Commit-Position: refs/heads/master@{#19137}
Committed: https://chromium.googlesource.com/external/webrtc/+/7fb11d737661f5b8c00baeab278e9f08c64a1be1

[eladalon, 2017-07-25 11:55:16]

eladalon@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[eladalon, 2017-07-25 11:55:18]

PTAL

[danilchap, 2017-07-25 14:05:41]

https://codereview.webrtc.org/2984973002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc (right):

https://codereview.webrtc.org/2984973002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:427: {
I think extra indentation make it less readable.
specially that you do not need it.

[eladalon, 2017-07-25 14:28:49]

https://codereview.webrtc.org/2984973002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc (right):

https://codereview.webrtc.org/2984973002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:427: {
On 2017/07/25 14:05:41, danilchap wrote:
> I think extra indentation make it less readable.
> specially that you do not need it.

I'm not sure I don't need this - I am not familiar enough with what operations
return-StatisticianMap would trigger if RVO is not used, and what part of this
is compiler-dependent and what is mandated by C++. But it's probably not
important enough, and given that this is already an improvement over the state
before, I'll change.

[danilchap, 2017-07-25 14:32:32]

lgtm

[eladalon, 2017-07-25 14:36:47]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-07-25 14:36:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-25 15:25:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500993407661700,
"parent_rev": "6209dcdeb13558eac8dc4e2a785adbf19606b7ee", "commit_rev":
"7fb11d737661f5b8c00baeab278e9f08c64a1be1"}

[commit-bot: I haz the power, 2017-07-25 15:25:28]

Description was changed from

==========
Shrink critical-section scope in ReceiveStatisticsImpl::GetActiveStatisticians()

The critical-section's scope can be shrunk (we can hold the lock for a shorter
time).

BUG=None
==========

to

==========
Shrink critical-section scope in ReceiveStatisticsImpl::GetActiveStatisticians()

The critical-section's scope can be shrunk (we can hold the lock for a shorter
time).

BUG=None

Review-Url: https://codereview.webrtc.org/2984973002
Cr-Commit-Position: refs/heads/master@{#19137}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7fb11d737661f5b8c00baeab2...
==========

[commit-bot: I haz the power, 2017-07-25 15:25:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7fb11d737661f5b8c00baeab2...