Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2984893002: Removed files that were missed during migration and fixed status file. (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 5 months ago
Reviewers:
jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed files that were missed during migration and fixed status file. Migrated test block 29 to Dart 2.0 -Spit string_test into string_test and string_static_test -Added various MissingCompileTimeError entries in status files for tests which throw exceptions on configurations that haven't implemented Dart 2.0 -Switched var -> dynamic in symbol_operator_test TBR=jcollins@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8247191e280eb97b7eff4ef8fcbbd0ffd2946f35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -2183 lines) Patch
M tests/corelib/corelib.status View 6 chunks +0 lines, -62 lines 0 comments Download
D tests/corelib/string_substring_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib/string_test.dart View 1 chunk +0 lines, -494 lines 0 comments Download
D tests/corelib/string_to_lower_case_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/corelib/string_trim2_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/corelib/string_trim_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/corelib/string_trimlr_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/corelib/strings_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib/symbol_operator_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/corelib/symbol_reserved_word_test.dart View 1 chunk +0 lines, -124 lines 0 comments Download
D tests/corelib/symbol_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 4 chunks +80 lines, -0 lines 0 comments Download
A tests/corelib_2/string_static_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A + tests/corelib_2/string_substring_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_test.dart View 2 chunks +0 lines, -16 lines 0 comments Download
A + tests/corelib_2/string_to_lower_case_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_trim2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_trim_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_trimlr_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/strings_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/symbol_operator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib_2/symbol_reserved_word_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib_2/symbol_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -6 lines 0 comments Download
D tests/corelib_strong/string_substring_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib_strong/string_test.dart View 1 chunk +0 lines, -494 lines 0 comments Download
D tests/corelib_strong/string_to_lower_case_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/corelib_strong/string_trim2_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/corelib_strong/string_trim_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/corelib_strong/string_trimlr_test.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D tests/corelib_strong/strings_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib_strong/symbol_operator_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/corelib_strong/symbol_reserved_word_test.dart View 1 chunk +0 lines, -124 lines 0 comments Download
D tests/corelib_strong/symbol_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bkonyi
3 years, 5 months ago (2017-07-23 03:44:04 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8247191e280eb97b7eff4ef8fcbbd0ffd2946f35.

Powered by Google App Engine
This is Rietveld 408576698