Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)
Patch Set: Resolve conflicts. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-add-languages-dialog' is a dialog for enabling 6 * @fileoverview 'settings-add-languages-dialog' is a dialog for enabling
7 * languages. 7 * languages.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-add-languages-dialog', 10 is: 'settings-add-languages-dialog',
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 }, 58 },
59 59
60 /** 60 /**
61 * @return {!Array<!chrome.languageSettingsPrivate.Language>} A list of 61 * @return {!Array<!chrome.languageSettingsPrivate.Language>} A list of
62 * languages to be displayed. 62 * languages to be displayed.
63 * @private 63 * @private
64 */ 64 */
65 getLanguages_: function() { 65 getLanguages_: function() {
66 var filterValue = 66 var filterValue =
67 this.filterValue_ ? this.filterValue_.toLowerCase() : null; 67 this.filterValue_ ? this.filterValue_.toLowerCase() : null;
68 return this.languages.supported.filter(function(language) { 68 return this.languages.supported.filter(language => {
69 var isAvailableLanguage = 69 var isAvailableLanguage =
70 !this.languageHelper.isLanguageEnabled(language.code); 70 !this.languageHelper.isLanguageEnabled(language.code);
71 71
72 if (!isAvailableLanguage) 72 if (!isAvailableLanguage)
73 return false; 73 return false;
74 74
75 if (filterValue === null) 75 if (filterValue === null)
76 return true; 76 return true;
77 77
78 return language.displayName.toLowerCase().includes(filterValue) || 78 return language.displayName.toLowerCase().includes(filterValue) ||
79 language.nativeDisplayName.toLowerCase().includes(filterValue); 79 language.nativeDisplayName.toLowerCase().includes(filterValue);
80 }.bind(this)); 80 });
81 }, 81 },
82 82
83 /** 83 /**
84 * @param {!chrome.languageSettingsPrivate.Language} language 84 * @param {!chrome.languageSettingsPrivate.Language} language
85 * @return {string} The text to be displayed. 85 * @return {string} The text to be displayed.
86 * @private 86 * @private
87 */ 87 */
88 getDisplayText_: function(language) { 88 getDisplayText_: function(language) {
89 var displayText = language.displayName; 89 var displayText = language.displayName;
90 // If the native name is different, add it. 90 // If the native name is different, add it.
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 onCancelButtonTap_: function() { 127 onCancelButtonTap_: function() {
128 this.$.dialog.close(); 128 this.$.dialog.close();
129 }, 129 },
130 130
131 /** 131 /**
132 * Enables the checked languages. 132 * Enables the checked languages.
133 * @private 133 * @private
134 */ 134 */
135 onActionButtonTap_: function() { 135 onActionButtonTap_: function() {
136 this.$.dialog.close(); 136 this.$.dialog.close();
137 this.languagesToAdd_.forEach(function(languageCode) { 137 this.languagesToAdd_.forEach(languageCode => {
138 this.languageHelper.enableLanguage(languageCode); 138 this.languageHelper.enableLanguage(languageCode);
139 }.bind(this)); 139 });
140 }, 140 },
141 }); 141 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698