Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)
Patch Set: Resolve conflicts. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/about_page/about_page_browser_proxy.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-about-page' contains version and OS related 6 * @fileoverview 'settings-about-page' contains version and OS related
7 * information. 7 * information.
8 */ 8 */
9 9
10 Polymer({ 10 Polymer({
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 129
130 /** @override */ 130 /** @override */
131 attached: function() { 131 attached: function() {
132 this.aboutBrowserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance(); 132 this.aboutBrowserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance();
133 this.aboutBrowserProxy_.pageReady(); 133 this.aboutBrowserProxy_.pageReady();
134 134
135 this.lifetimeBrowserProxy_ = 135 this.lifetimeBrowserProxy_ =
136 settings.LifetimeBrowserProxyImpl.getInstance(); 136 settings.LifetimeBrowserProxyImpl.getInstance();
137 137
138 // <if expr="chromeos"> 138 // <if expr="chromeos">
139 this.addEventListener('target-channel-changed', function(e) { 139 this.addEventListener('target-channel-changed', e => {
140 this.targetChannel_ = e.detail; 140 this.targetChannel_ = e.detail;
141 }.bind(this)); 141 });
142 142
143 this.aboutBrowserProxy_.getChannelInfo().then(function(info) { 143 this.aboutBrowserProxy_.getChannelInfo().then(info => {
144 this.currentChannel_ = info.currentChannel; 144 this.currentChannel_ = info.currentChannel;
145 this.targetChannel_ = info.targetChannel; 145 this.targetChannel_ = info.targetChannel;
146 this.startListening_(); 146 this.startListening_();
147 }.bind(this)); 147 });
148 148
149 this.aboutBrowserProxy_.getRegulatoryInfo().then(function(info) { 149 this.aboutBrowserProxy_.getRegulatoryInfo().then(info => {
150 this.regulatoryInfo_ = info; 150 this.regulatoryInfo_ = info;
151 }.bind(this)); 151 });
152 // </if> 152 // </if>
153 // <if expr="not chromeos"> 153 // <if expr="not chromeos">
154 this.startListening_(); 154 this.startListening_();
155 // </if> 155 // </if>
156 if (settings.getQueryParameters().get('checkForUpdate') == 'true') { 156 if (settings.getQueryParameters().get('checkForUpdate') == 'true') {
157 this.onCheckUpdatesTap_(); 157 this.onCheckUpdatesTap_();
158 } 158 }
159 }, 159 },
160 160
161 /** @private */ 161 /** @private */
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 }); 457 });
458 }, 458 },
459 459
460 // <if expr="_google_chrome"> 460 // <if expr="_google_chrome">
461 /** @private */ 461 /** @private */
462 onReportIssueTap_: function() { 462 onReportIssueTap_: function() {
463 this.aboutBrowserProxy_.openFeedbackDialog(); 463 this.aboutBrowserProxy_.openFeedbackDialog();
464 }, 464 },
465 // </if> 465 // </if>
466 }); 466 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/about_page/about_page_browser_proxy.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698