Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2984473002: Move total audio energy and duration tracking to AudioLevel and protect with existing critial secti… (Closed)

Created:
3 years, 5 months ago by Zach Stein
Modified:
3 years, 5 months ago
Reviewers:
ossu, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, ossu, niklas.enbom
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move total audio energy and duration tracking to AudioLevel and protect with existing critial section. BUG=webrtc:7982 Review-Url: https://codereview.webrtc.org/2984473002 Cr-Commit-Position: refs/heads/master@{#19105} Committed: https://chromium.googlesource.com/external/webrtc/+/3c45186ef24f3cb401e10aac77af0f5c18c8f264

Patch Set 1 #

Patch Set 2 : Initialize new AudioLevel members to 0.0. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M webrtc/voice_engine/audio_level.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M webrtc/voice_engine/audio_level.cc View 2 chunks +23 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 2 chunks +4 lines, -15 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 2 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
Zach Stein
PTAL
3 years, 5 months ago (2017-07-17 22:13:23 UTC) #11
henrika_webrtc
+ossu
3 years, 5 months ago (2017-07-19 08:01:41 UTC) #12
ossu
This LGTM. Wanna run the linux_internal trybot just to be on the safe side?
3 years, 5 months ago (2017-07-19 09:41:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2984473002/40001
3 years, 5 months ago (2017-07-19 20:49:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19436)
3 years, 5 months ago (2017-07-19 20:56:07 UTC) #20
henrika_webrtc
lgtm
3 years, 5 months ago (2017-07-20 07:59:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2984473002/40001
3 years, 5 months ago (2017-07-20 16:54:08 UTC) #23
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 16:57:49 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/3c45186ef24f3cb401e10aac7...

Powered by Google App Engine
This is Rietveld 408576698