Improved UI for event_log_analyzer tool

Improved UI for event_log_analyzer tool

- Don't plot every graph by default.
- Change --plot_all to --plot_profile=(all|none|default).
- Some other minor cleanups.

BUG=webrtc:8017
Review-Url: https://codereview.webrtc.org/2983983002
Cr-Commit-Position: refs/heads/master@{#19348}
Committed: https://chromium.googlesource.com/external/webrtc/+/2ee076dfa35014adc7869972da6454bf2391c223

[terelius, 2017-07-20 17:46:48]

terelius@webrtc.org changed reviewers:
+ tschumim@webrtc.org

[terelius, 2017-07-21 10:56:22]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-21 10:56:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-07-21 10:56:52]

terelius@webrtc.org changed reviewers:
+ minyue@webrtc.org

[commit-bot: I haz the power, 2017-07-21 11:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-21 11:18:20]

Dry run: This issue passed the CQ dry run.

[minyue-webrtc, 2017-07-21 15:08:43]

https://codereview.webrtc.org/2983983002/diff/60001/webrtc/rtc_tools/event_lo...
File webrtc/rtc_tools/event_log_visualizer/main.cc (right):

https://codereview.webrtc.org/2983983002/diff/60001/webrtc/rtc_tools/event_lo...
webrtc/rtc_tools/event_log_visualizer/main.cc:174: if (FLAG_incoming) {
I would suggest remove FLAG_incoming and FLAG_outgoing and split
plot_packet_count into plot_incoming_packet_count and plot_outgoing_packet_count

Same with others

[terelius, 2017-08-08 11:01:42]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-08 11:01:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-08 11:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-08 11:03:23]

Dry run: Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/26312)
  linux_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...)
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[terelius, 2017-08-08 12:14:56]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-08 12:14:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-08-08 12:16:00]

tschumi, could you take a look?

https://codereview.webrtc.org/2983983002/diff/60001/webrtc/rtc_tools/event_lo...
File webrtc/rtc_tools/event_log_visualizer/main.cc (right):

https://codereview.webrtc.org/2983983002/diff/60001/webrtc/rtc_tools/event_lo...
webrtc/rtc_tools/event_log_visualizer/main.cc:174: if (FLAG_incoming) {
On 2017/07/21 15:08:43, minyue-webrtc(OOOuntilAug13) wrote:
> I would suggest remove FLAG_incoming and FLAG_outgoing and split
> plot_packet_count into plot_incoming_packet_count and
plot_outgoing_packet_count
> 
> Same with others

Done.

[commit-bot: I haz the power, 2017-08-08 12:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-08 12:40:14]

Dry run: This issue passed the CQ dry run.

[terelius, 2017-08-09 13:24:05]

On 2017/08/08 12:16:00, terelius wrote:
> tschumi, could you take a look?
> 
>
https://codereview.webrtc.org/2983983002/diff/60001/webrtc/rtc_tools/event_lo...
> File webrtc/rtc_tools/event_log_visualizer/main.cc (right):
> 
>
https://codereview.webrtc.org/2983983002/diff/60001/webrtc/rtc_tools/event_lo...
> webrtc/rtc_tools/event_log_visualizer/main.cc:174: if (FLAG_incoming) {
> On 2017/07/21 15:08:43, minyue-webrtc(OOOuntilAug13) wrote:
> > I would suggest remove FLAG_incoming and FLAG_outgoing and split
> > plot_packet_count into plot_incoming_packet_count and
> plot_outgoing_packet_count
> > 
> > Same with others
> 
> Done.

ping. I have 2 follow-up CLs to waiting on this one. :)

[tschumi, 2017-08-15 06:57:42]

lgtm

[minyue-webrtc, 2017-08-15 07:47:15]

lgtm

[terelius, 2017-08-15 08:18:39]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2017-08-15 08:18:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-15 09:04:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1502785119564550,
"parent_rev": "6bdcefce80b42ddc7e8c754988f86c8e214aee83", "commit_rev":
"2ee076dfa35014adc7869972da6454bf2391c223"}

[commit-bot: I haz the power, 2017-08-15 09:04:12]

Description was changed from

==========
Improved UI for event_log_analyzer tool

- Don't plot every graph by default.
- Change --plot_all to --plot_profile=(all|none|default).
- Some other minor cleanups.

BUG=webrtc:8017
==========

to

==========
Improved UI for event_log_analyzer tool

- Don't plot every graph by default.
- Change --plot_all to --plot_profile=(all|none|default).
- Some other minor cleanups.

BUG=webrtc:8017

Review-Url: https://codereview.webrtc.org/2983983002
Cr-Commit-Position: refs/heads/master@{#19348}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2ee076dfa35014adc7869972d...
==========

[commit-bot: I haz the power, 2017-08-15 09:04:13]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/2ee076dfa35014adc7869972d...