Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2983583002: [Webrtc] Reenable libc++ on ubsan (Closed)

Created:
3 years, 5 months ago by Tom (Use chromium acct)
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

[Webrtc] Reenable libc++ on ubsan BUG=webrtc:7922 R=ehmaldonado@webrtc.org Review-Url: https://codereview.webrtc.org/2983583002 Cr-Commit-Position: refs/heads/master@{#19080} Committed: https://chromium.googlesource.com/external/webrtc/+/153e204e5d29472d1d0700b4f7dca16733b6b620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools_webrtc/mb/mb_config.pyl View 1 chunk +1 line, -2 lines 0 comments Download
M tools_webrtc/ubsan/vptr_blacklist.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Tom Anderson
oprypin@ ptal
3 years, 5 months ago (2017-07-14 18:02:12 UTC) #3
Tom Anderson
ping. still need approval on this one
3 years, 5 months ago (2017-07-18 03:37:01 UTC) #8
ehmaldonado_webrtc
On 2017/07/18 03:37:01, Tom Anderson wrote: > ping. still need approval on this one LGTM
3 years, 5 months ago (2017-07-18 06:04:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2983583002/1
3 years, 5 months ago (2017-07-18 07:51:07 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19375)
3 years, 5 months ago (2017-07-18 07:57:31 UTC) #13
oprypin_webrtc
On 2017/07/18 07:57:31, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 5 months ago (2017-07-18 13:30:27 UTC) #15
pbos-webrtc
lgtm
3 years, 5 months ago (2017-07-18 15:34:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2983583002/1
3 years, 5 months ago (2017-07-18 17:39:18 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-07-18 17:51:14 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/153e204e5d29472d1d0700b4f...

Powered by Google App Engine
This is Rietveld 408576698