Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 2983573002: nit: Avoid pointer-to-unique_ptr in RtcEventLogImpl (Closed)

Created:
3 years, 5 months ago by eladalon
Modified:
3 years, 5 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

nit: Avoid pointer-to-unique_ptr in RtcEventLogImpl BUG=None Review-Url: https://codereview.webrtc.org/2983573002 Cr-Commit-Position: refs/heads/master@{#19052} Committed: https://chromium.googlesource.com/external/webrtc/+/333264f0897dbde2268267af4ba701e6c0445b95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 14 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
eladalon
PTAL
3 years, 5 months ago (2017-07-14 16:48:39 UTC) #2
terelius
lgtm
3 years, 5 months ago (2017-07-14 17:18:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2983573002/1
3 years, 5 months ago (2017-07-16 23:23:16 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-16 23:44:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/333264f0897dbde2268267af4...

Powered by Google App Engine
This is Rietveld 408576698