Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 2983363002: Remove NullObjectReceiveStatistics() in rtp_rtcp module (Closed)

Created:
3 years, 5 months ago by danilchap
Modified:
3 years, 5 months ago
Reviewers:
eladalon
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove NullObjectReceiveStatistics() in rtp_rtcp module use (already supported) nullptr as indication for no statistics BUG=webrtc:8016 Review-Url: https://codereview.webrtc.org/2983363002 Cr-Commit-Position: refs/heads/master@{#19129} Committed: https://chromium.googlesource.com/external/webrtc/+/d3f3c3497bad07a5346269d4e5b2afda7c266cc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
danilchap
3 years, 5 months ago (2017-07-24 16:50:43 UTC) #3
eladalon
lgtm
3 years, 5 months ago (2017-07-25 10:28:03 UTC) #4
eladalon
lgtm
3 years, 5 months ago (2017-07-25 10:28:05 UTC) #5
eladalon
On 2017/07/25 10:28:05, eladalon wrote: > lgtm Odd interface... :-)
3 years, 5 months ago (2017-07-25 10:28:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2983363002/1
3 years, 5 months ago (2017-07-25 10:37:47 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 11:20:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d3f3c3497bad07a5346269d4e...

Powered by Google App Engine
This is Rietveld 408576698