Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2983253002: Migrated test block 29 to Dart 2.0 (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 29 to Dart 2.0 -Spit string_test into string_test and string_static_test -Added various MissingCompileTimeError entries in status files for tests which throw exceptions on configurations that haven't implemented Dart 2.0 -Switched var -> dynamic in symbol_operator_test BUG= R=jcollins@google.com, rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/3867d84ca5aa1dc3c7019de65f9f37c6a3ab5bfc

Patch Set 1 #

Patch Set 2 : Migrated test block 29 to Dart 2.0 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1972 lines) Patch
M tests/corelib/corelib.status View 6 chunks +0 lines, -65 lines 0 comments Download
D tests/corelib/string_substring_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib/string_test.dart View 1 chunk +0 lines, -494 lines 0 comments Download
D tests/corelib/string_to_lower_case_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/corelib/string_trim2_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/corelib/string_trim_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/corelib/string_trimlr_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/corelib/strings_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib/symbol_operator_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 4 chunks +79 lines, -0 lines 0 comments Download
A tests/corelib_2/string_static_test.dart View 1 chunk +14 lines, -0 lines 1 comment Download
A + tests/corelib_2/string_substring_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_test.dart View 2 chunks +0 lines, -16 lines 0 comments Download
A + tests/corelib_2/string_to_lower_case_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_trim2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_trim_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_trimlr_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/strings_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/symbol_operator_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib_2/symbol_reserved_word_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib_2/symbol_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 2 chunks +0 lines, -6 lines 0 comments Download
D tests/corelib_strong/string_substring_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib_strong/string_test.dart View 1 chunk +0 lines, -494 lines 0 comments Download
D tests/corelib_strong/string_to_lower_case_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/corelib_strong/string_trim2_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/corelib_strong/string_trim_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/corelib_strong/string_trimlr_test.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D tests/corelib_strong/strings_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib_strong/symbol_operator_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/corelib_strong/symbol_reserved_word_test.dart View 1 chunk +0 lines, -124 lines 0 comments Download
D tests/corelib_strong/symbol_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bkonyi
3 years, 5 months ago (2017-07-21 13:21:43 UTC) #2
jcollins
LGTM Recommend trying the additional command lines for --checked, --strong etc I just added to ...
3 years, 5 months ago (2017-07-21 19:01:17 UTC) #3
Bob Nystrom
https://codereview.chromium.org/2983253002/diff/20001/tests/corelib_2/string_static_test.dart File tests/corelib_2/string_static_test.dart (right): https://codereview.chromium.org/2983253002/diff/20001/tests/corelib_2/string_static_test.dart#newcode13 tests/corelib_2/string_static_test.dart:13: var c = a[2.2]; /*@compile-error=unspecified*/ I would move the ...
3 years, 5 months ago (2017-07-21 22:03:26 UTC) #4
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-21 22:03:30 UTC) #5
bkonyi
3 years, 5 months ago (2017-07-23 03:16:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3867d84ca5aa1dc3c7019de65f9f37c6a3ab5bfc.

Powered by Google App Engine
This is Rietveld 408576698