Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2982213002: Add support for capturers to capture VideoFrames. (Closed)

Created:
3 years, 5 months ago by sakal
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add support for capturers to capture VideoFrames. BUG=webrtc:7749, webrtc:7760 Review-Url: https://codereview.webrtc.org/2982213002 Cr-Commit-Position: refs/heads/master@{#19318} Committed: https://chromium.googlesource.com/external/webrtc/+/be910460e082af04489a76a3b9fee571756af10b

Patch Set 1 #

Patch Set 2 : Fix tests. #

Patch Set 3 : Remove accidental whitespace. #

Patch Set 4 : Cleanup. #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Address comments. #

Patch Set 9 : Rebase #

Patch Set 10 : Minor changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -6 lines) Patch
M webrtc/sdk/android/api/org/webrtc/VideoCapturer.java View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/FileVideoCapturerTest.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/AndroidVideoTrackSourceObserver.java View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource.h View 1 2 3 4 5 6 3 chunks +12 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource.cc View 1 2 3 4 5 6 3 chunks +48 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource_jni.cc View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/native_handle_impl.h View 1 2 3 4 5 6 7 8 9 2 chunks +23 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/native_handle_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
sakal
PTAL
3 years, 5 months ago (2017-07-21 13:08:37 UTC) #3
magjed_webrtc
lgtm
3 years, 5 months ago (2017-07-24 09:21:32 UTC) #4
sakal
PTAL
3 years, 4 months ago (2017-08-10 12:06:58 UTC) #11
kthelgason
lgtm
3 years, 4 months ago (2017-08-11 07:14:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2982213002/220001
3 years, 4 months ago (2017-08-11 07:23:22 UTC) #20
commit-bot: I haz the power
3 years, 4 months ago (2017-08-11 07:26:15 UTC) #23
Message was sent while issue was closed.
Committed patchset #10 (id:220001) as
https://chromium.googlesource.com/external/webrtc/+/be910460e082af04489a76a3b...

Powered by Google App Engine
This is Rietveld 408576698