Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2982133002:
Fix gtest-parallel-wrapper (Closed)
|
Created:
3 years, 5 months ago by ehmaldonado_webrtc Modified:
3 years, 5 months ago Reviewers:
oprypin_webrtc CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix gtest-parallel-wrapper
It doesn't work when '--' is not part of the command line.
It executed "gtest-parallel gtest-parallel-wrapper.py executable_name"
instead of "gtets-parallel executable_name".
NOTRY=True
TBR=kjellander@webrtc.org
BUG=None
Review-Url: https://codereview.webrtc.org/2982133002
Cr-Commit-Position: refs/heads/master@{#19077}
Committed: https://chromium.googlesource.com/external/webrtc/+/f549dffa7b9f0f554d1bc7eeaa54b9f1d0097ee6
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
Description was changed from ========== It doesn't work when '--' is not part of the command line. It executes "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". BUG=None ========== to ========== It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". BUG=None ==========
ehmaldonado@webrtc.org changed reviewers: + oprypin@webrtc.org
Description was changed from ========== It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". BUG=None ========== to ========== Fix gtest-parallel-wrapper It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". BUG=None ==========
On 2017/07/18 14:20:21, ehmaldonado_webrtc wrote: lgtm
The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Fix gtest-parallel-wrapper It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". BUG=None ========== to ========== Fix gtest-parallel-wrapper It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". NOTRY=True BUG=None ==========
The CQ bit was unchecked by ehmaldonado@webrtc.org
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19394)
Description was changed from ========== Fix gtest-parallel-wrapper It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". NOTRY=True BUG=None ========== to ========== Fix gtest-parallel-wrapper It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". NOTRY=True TBR=kjellander@webrtc.org BUG=None ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1500390798720950, "parent_rev":
"80c829f25382f98e97b30a5803322552f350f983", "commit_rev":
"f549dffa7b9f0f554d1bc7eeaa54b9f1d0097ee6"}
Message was sent while issue was closed.
Description was changed from ========== Fix gtest-parallel-wrapper It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". NOTRY=True TBR=kjellander@webrtc.org BUG=None ========== to ========== Fix gtest-parallel-wrapper It doesn't work when '--' is not part of the command line. It executed "gtest-parallel gtest-parallel-wrapper.py executable_name" instead of "gtets-parallel executable_name". NOTRY=True TBR=kjellander@webrtc.org BUG=None Review-Url: https://codereview.webrtc.org/2982133002 Cr-Commit-Position: refs/heads/master@{#19077} Committed: https://chromium.googlesource.com/external/webrtc/+/f549dffa7b9f0f554d1bc7eea... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/f549dffa7b9f0f554d1bc7eea... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
