Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 2982053002: Revert "Prefer external video codecs over internal in SDP" (Closed)

Created:
3 years, 5 months ago by minyue-webrtc
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Prefer external video codecs over internal in SDP" This reverts commit 06f3aae345854ba9dcc5ae3b603de1f86505acf9. The reason for reverting is that it seems to break Chromium importer. See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28K%20Nexus5%29/builds/17862 BUG=chromium:688541 TBR=magjed@webrtc.org Review-Url: https://codereview.webrtc.org/2982053002 Cr-Commit-Position: refs/heads/master@{#19058} Committed: https://chromium.googlesource.com/external/webrtc/+/f032e4041cfa55353c7d63bebb3187ec4c877157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M webrtc/media/engine/webrtcvideoengine.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine_unittest.cc View 4 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (12 generated)
henrika_webrtc
lgtm
3 years, 5 months ago (2017-07-17 15:12:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2982053002/1
3 years, 5 months ago (2017-07-17 15:14:09 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 15:45:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f032e4041cfa55353c7d63beb...

Powered by Google App Engine
This is Rietveld 408576698