Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2981893002:
[Webrtc] Reenable libc++ on gcc (Closed)
|
Created:
3 years, 5 months ago by Tom (Use chromium acct) Modified:
3 years, 5 months ago CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
Description[Webrtc] Reenable libc++ on gcc
BUG=webrtc:7922
R=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2981893002
Cr-Commit-Position: refs/heads/master@{#19066}
Committed: https://chromium.googlesource.com/external/webrtc/+/3124cc6921dcc4bc774236dccec0f163e86b80e5
Patch Set 1 : revert DEPS change #
Messages
Total messages: 19 (14 generated)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...) linux_ubsan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/13905)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
oprypin@ ptal
Description was changed from ========== [Webrtc] Reenable libc++ on gcc BUG=webrtc:7922 R=oprypin@webrtc.org ========== to ========== [Webrtc] Reenable libc++ on gcc BUG=webrtc:7922 R=ehmaldonado@webrtc.org ==========
oprypin@webrtc.org changed reviewers: + ehmaldonado@webrtc.org
On 2017/07/14 18:43:37, Tom Anderson wrote: > oprypin@ ptal LGTM - though I'm not an owner. Let's not land these until next week. Thanks for taking this task!
On 2017/07/14 18:53:58, oprypin_webrtc wrote: > On 2017/07/14 18:43:37, Tom Anderson wrote: > > oprypin@ ptal > > LGTM - though I'm not an owner. > Let's not land these until next week. > > Thanks for taking this task! lgtm too :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500348986727260,
"parent_rev": "89ac292ba2ebcfa47a37c8f7c5465cb0368aba0c", "commit_rev":
"3124cc6921dcc4bc774236dccec0f163e86b80e5"}
Message was sent while issue was closed.
Description was changed from ========== [Webrtc] Reenable libc++ on gcc BUG=webrtc:7922 R=ehmaldonado@webrtc.org ========== to ========== [Webrtc] Reenable libc++ on gcc BUG=webrtc:7922 R=ehmaldonado@webrtc.org Review-Url: https://codereview.webrtc.org/2981893002 Cr-Commit-Position: refs/heads/master@{#19066} Committed: https://chromium.googlesource.com/external/webrtc/+/3124cc6921dcc4bc774236dcc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/3124cc6921dcc4bc774236dcc... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
