Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2981793002: Reset isFirstFrameRendered on init of SurfaceViewRenderer (Closed)

Created:
3 years, 5 months ago by ctserng
Modified:
3 years, 5 months ago
Reviewers:
magjed_webrtc
CC:
niklas.enbom, peah-webrtc, qiang.lu, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reset isFirstFrameRendered on init of SurfaceViewRenderer If a SurfaceViewRenderer is reinitialized, the onFirstFrameRendered callback is not fired. Ensure that we reset the flag when the SurfaceViewRenderer is initialized. BUG=webrtc:7985 Review-Url: https://codereview.webrtc.org/2981793002 Cr-Commit-Position: refs/heads/master@{#19016} Committed: https://chromium.googlesource.com/external/webrtc/+/ff7acb19a16d9604cf3e54f2cd4ebfa6cb5e8fc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ctserng
PTAL
3 years, 5 months ago (2017-07-13 21:12:24 UTC) #2
magjed_webrtc
lgtm
3 years, 5 months ago (2017-07-14 09:02:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2981793002/1
3 years, 5 months ago (2017-07-14 09:03:01 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 09:35:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ff7acb19a16d9604cf3e54f2c...

Powered by Google App Engine
This is Rietveld 408576698