webrtc/pc/rtptransport.h - Issue 2980923002: SignalPacketReceived should pass packet as a pointer instead of a non-const reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/rtptransport.h

Issue 2980923002: SignalPacketReceived should pass packet as a pointer instead of a non-const reference. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/rtptransport.h

diff --git a/webrtc/pc/rtptransport.h b/webrtc/pc/rtptransport.h

index 87f29bac2a1be173411e6c086c5a7e064f2f0ab1..a86fa126bb8569cdaaafda36a0064285542e5fd4 100644

--- a/webrtc/pc/rtptransport.h

+++ b/webrtc/pc/rtptransport.h

@@ -73,7 +73,7 @@ class RtpTransport : public RtpTransportInterface, public sigslot::has_slots<> {

// TODO(zstein): Consider having two signals - RtcPacketReceived and

// RtcpPacketReceived.

// The first argument is true for RTCP packets and false for RTP packets.

- sigslot::signal3<bool, rtc::CopyOnWriteBuffer&, const rtc::PacketTime&>

+ sigslot::signal3<bool, rtc::CopyOnWriteBuffer*, const rtc::PacketTime&>

SignalPacketReceived;

protected:

« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/rtptransport.cc » ('j') | no next file with comments »