|
|
DescriptionUpdate .gn to set a min SDK for macOS.
Currently, WebRTC is setting this config via mac_sdk_min_build_override. The old
mechanism is deprecated, but cannot be removed until chromium is updated to no
longer require mac_sdk_min_build_override.
BUG=chromium:740693
TBR=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2979603002
Cr-Commit-Position: refs/heads/master@{#19006}
Committed: https://chromium.googlesource.com/external/webrtc/+/0ff780005965f366d7238773127999dda15c6a1b
Patch Set 1 #Patch Set 2 : Use .gn instead of mb_config. #Messages
Total messages: 36 (26 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
erikchen@chromium.org changed reviewers: + ehmaldonado@chromium.org
ehmaldonado: Please review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Update mb config to set a min SDK for macOS via GN. Currently, WebRTC is setting this config via mac_sdk_min_build_override. The new method is the better mechanism. The old method cannot be removed until chromium is updated to no longer require mac_sdk_min_build_override. BUG=chromium:740693 ========== to ========== Update .gn to set a min SDK for macOS. Currently, WebRTC is setting this config via mac_sdk_min_build_override. The old mechanism is deprecated, but cannot be removed until chromium is updated to no longer require mac_sdk_min_build_override. BUG=chromium:740693 ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/...) mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/26182) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/23023) mac_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/27293)
Patchset #3 (id:40001) has been deleted
On 2017/07/10 23:21:10, erikchen wrote: > ehmaldonado: Please review. This produces an error: /b/build/slave/linux64_libfuzzer/build/src/buildtools/linux64/gn gen //out/Release --check ERROR at //.gn:40:17: Build argument has no effect. mac_sdk_min = "10.11" ^------ The variable "mac_sdk_min" was set as a build argument but never appeared in a declare_args() block in any buildfile. To view all possible args, run "gn args --list <builddir>" Done. Made 384 targets from 131 files in 673ms
On 2017/07/11 12:02:43, ehmaldonado_webrtc wrote: > On 2017/07/10 23:21:10, erikchen wrote: > > ehmaldonado: Please review. > > This produces an error: > > /b/build/slave/linux64_libfuzzer/build/src/buildtools/linux64/gn gen > //out/Release --check > ERROR at //.gn:40:17: Build argument has no effect. > mac_sdk_min = "10.11" > ^------ > The variable "mac_sdk_min" was set as a build argument > but never appeared in a declare_args() block in any buildfile. > > To view all possible args, run "gn args --list <builddir>" > Done. Made 384 targets from 131 files in 673ms This is fixed by https://chromium-review.googlesource.com/c/566595/, which will be fixed the next time Chrome is rolled into webrtc.
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/07/13 05:18:40, erikchen wrote: > On 2017/07/11 12:02:43, ehmaldonado_webrtc wrote: > > On 2017/07/10 23:21:10, erikchen wrote: > > > ehmaldonado: Please review. > > > > This produces an error: > > > > /b/build/slave/linux64_libfuzzer/build/src/buildtools/linux64/gn gen > > //out/Release --check > > ERROR at //.gn:40:17: Build argument has no effect. > > mac_sdk_min = "10.11" > > ^------ > > The variable "mac_sdk_min" was set as a build argument > > but never appeared in a declare_args() block in any buildfile. > > > > To view all possible args, run "gn args --list <builddir>" > > Done. Made 384 targets from 131 files in 673ms > > This is fixed by https://chromium-review.googlesource.com/c/566595/, which will > be fixed the next time Chrome is rolled into webrtc. lgtm
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19250)
On 2017/07/13 15:57:01, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19250) Right. You might want to TBR kjellander@
Description was changed from ========== Update .gn to set a min SDK for macOS. Currently, WebRTC is setting this config via mac_sdk_min_build_override. The old mechanism is deprecated, but cannot be removed until chromium is updated to no longer require mac_sdk_min_build_override. BUG=chromium:740693 ========== to ========== Update .gn to set a min SDK for macOS. Currently, WebRTC is setting this config via mac_sdk_min_build_override. The old mechanism is deprecated, but cannot be removed until chromium is updated to no longer require mac_sdk_min_build_override. BUG=chromium:740693 TBR=kjellander@webrtc.org ==========
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499961635855350, "parent_rev": "732a3437da4db7b452758b8e1cf26fce0ce3bf65", "commit_rev": "0ff780005965f366d7238773127999dda15c6a1b"}
Message was sent while issue was closed.
Description was changed from ========== Update .gn to set a min SDK for macOS. Currently, WebRTC is setting this config via mac_sdk_min_build_override. The old mechanism is deprecated, but cannot be removed until chromium is updated to no longer require mac_sdk_min_build_override. BUG=chromium:740693 TBR=kjellander@webrtc.org ========== to ========== Update .gn to set a min SDK for macOS. Currently, WebRTC is setting this config via mac_sdk_min_build_override. The old mechanism is deprecated, but cannot be removed until chromium is updated to no longer require mac_sdk_min_build_override. BUG=chromium:740693 TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2979603002 Cr-Commit-Position: refs/heads/master@{#19006} Committed: https://chromium.googlesource.com/external/webrtc/+/0ff780005965f366d72387731... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/0ff780005965f366d72387731...
Message was sent while issue was closed.
kjellander@webrtc.org changed reviewers: + kjellander@webrtc.org
Message was sent while issue was closed.
lgtm |