Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2979543002: Fix flaky test VideoSendStreamTest.SendsKeepAlive (Closed)

Created:
3 years, 5 months ago by sprang_webrtc
Modified:
3 years, 5 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix flaky test VideoSendStreamTest.SendsKeepAlive Since the keep-alive payload type is not registered in the payload type map of FakeNetworkPipe, it will cause a DCHECK to trigger unless we're able to destroy the call before that. Just register it in the fake network as media type "any", it will be discarded early on the receive side anyway. BUG=webrtc:7964 Review-Url: https://codereview.webrtc.org/2979543002 Cr-Commit-Position: refs/heads/master@{#18953} Committed: https://chromium.googlesource.com/external/webrtc/+/d2702ef1108e9bd144738a69bcf4deb7edc57341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M webrtc/test/call_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/call_test.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sprang_webrtc
3 years, 5 months ago (2017-07-10 14:58:43 UTC) #2
henrika_webrtc
lgtm
3 years, 5 months ago (2017-07-10 15:05:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979543002/1
3 years, 5 months ago (2017-07-10 15:15:39 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 15:41:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d2702ef1108e9bd144738a69b...

Powered by Google App Engine
This is Rietveld 408576698