Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2979493003: Revert: Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on wt (Closed)

Created:
3 years, 5 months ago by mbonadei
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on wt (patchset #2 id:20001 of https://codereview.webrtc.org/2964863002/ ) Reason for revert: RemoveSink became pure virtual at the VideoTrackInterface level, which broke code that was subclassing VideoTrackInterface directly. So the CL can be re-landed without that change. Original issue's description: > Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on the worker thread. > > Added documentation of thread expectations for video tracks and sources to the API. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2964863002 > Cr-Commit-Position: refs/heads/master@{#18938} > Committed: https://chromium.googlesource.com/external/webrtc/+/f1377f722271b4b5a090d4dba10201031d31f20d TBR=deadbeef@webrtc.org,noahric@chromium.org,yujo@chromium.org,perkj@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.webrtc.org/2979493003 Cr-Commit-Position: refs/heads/master@{#18942} Committed: https://chromium.googlesource.com/external/webrtc/+/539d104e3e8263892f2680a12c1dc1dbfb98aa4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -61 lines) Patch
M webrtc/api/mediastreaminterface.h View 3 chunks +6 lines, -11 lines 0 comments Download
M webrtc/ortc/ortcfactory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/pc/mediastream_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/pc/rtpreceiver.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/pc/rtpsenderreceiver_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/pc/statscollector_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/pc/trackmediainfomap_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/pc/videotrack.h View 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/pc/videotrack.cc View 5 chunks +13 lines, -16 lines 0 comments Download
M webrtc/pc/videotrack_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
mbonadei
Created Revert of Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on wt
3 years, 5 months ago (2017-07-10 09:08:53 UTC) #2
Taylor Brandstetter
3 years, 5 months ago (2017-07-10 17:35:53 UTC) #5
Message was sent while issue was closed.
Updated description with more specific revert reason.

Powered by Google App Engine
This is Rietveld 408576698