Refactor composing report blocks for rtcp Sender/Receiver reports

webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc
index c1928071802e68a8ea7cc574bcfa43e4e805dde1..a16635855b7bcdf87f747b9966bd1c044be0a485 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc
@@ -10,6 +10,8 @@
 
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h"
 
+#include <utility>
+
 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h"
 #include "webrtc/rtc_base/checks.h"
@@ -93,5 +95,14 @@ bool ReceiverReport::AddReportBlock(const ReportBlock& block) {
   return true;
 }
 
+bool ReceiverReport::SetReportBlocks(std::vector<ReportBlock> blocks) {

[eladalon, 2017/07/21 12:53:19]

Not sure about this - what do you think of accepting (std::vector<ReportBlock>&&
blocks) instead?

[danilchap, 2017/07/21 17:11:13]

that is banned by style guide.
https://google.github.io/styleguide/cppguide.html#Rvalue_references

T&& in a function signature means 'may be move'
here it move parameter almost always so prefer a simpler signature.

+  if (blocks.size() > kMaxNumberOfReportBlocks) {
+    LOG(LS_WARNING) << "Max report blocks reached.";

[eladalon, 2017/07/21 12:53:19]

Maybe log blocks.size()

[danilchap, 2017/07/21 17:11:13]

Done.

+    return false;
+  }
+  report_blocks_ = std::move(blocks);
+  return true;
+}
+
 }  // namespace rtcp
 }  // namespace webrtc