Refactor composing report blocks for rtcp Sender/Receiver reports

webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h"
 
+#include <utility>
+
 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h"
 #include "webrtc/rtc_base/checks.h"
 #include "webrtc/rtc_base/logging.h"
 
 namespace webrtc {
 namespace rtcp {
 constexpr uint8_t ReceiverReport::kPacketType;
 // RTCP receiver report (RFC 3550).
 //
@@ skipping 63 matching lines @@
 
 bool ReceiverReport::AddReportBlock(const ReportBlock& block) {
   if (report_blocks_.size() >= kMaxNumberOfReportBlocks) {
     LOG(LS_WARNING) << "Max report blocks reached.";
     return false;
   }
   report_blocks_.push_back(block);
   return true;
 }
 
+bool ReceiverReport::SetReportBlocks(std::vector<ReportBlock> blocks) {

[eladalon, 2017/07/21 12:53:19]

Not sure about this - what do you think of accepting (std::vector<ReportBlock>&&
blocks) instead?

[danilchap, 2017/07/21 17:11:13]

that is banned by style guide.
https://google.github.io/styleguide/cppguide.html#Rvalue_references

T&& in a function signature means 'may be move'
here it move parameter almost always so prefer a simpler signature.

+  if (blocks.size() > kMaxNumberOfReportBlocks) {
+    LOG(LS_WARNING) << "Max report blocks reached.";

[eladalon, 2017/07/21 12:53:19]

Maybe log blocks.size()

[danilchap, 2017/07/21 17:11:13]

Done.

+    return false;
+  }
+  report_blocks_ = std::move(blocks);
+  return true;
+}
+
 }  // namespace rtcp
 }  // namespace webrtc