Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2979363002: Remove setting configuration parameter to itself. (Closed)

Created:
3 years, 5 months ago by danilchap
Modified:
3 years, 5 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove setting configuration parameter to itself. when creating RtpRtcp module for video send stream. BUG=webrtc:8016 Review-Url: https://codereview.webrtc.org/2979363002 Cr-Commit-Position: refs/heads/master@{#19122} Committed: https://chromium.googlesource.com/external/webrtc/+/c43d565873e3f2f84fad51ddb1629d5a3a1509ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/video/video_send_stream.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
danilchap
Would like to change slightly the type of this parameter.
3 years, 5 months ago (2017-07-24 08:44:54 UTC) #3
sprang_webrtc
lol lgtm
3 years, 5 months ago (2017-07-24 14:34:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979363002/1
3 years, 5 months ago (2017-07-24 14:37:41 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-24 15:13:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c43d565873e3f2f84fad51ddb...

Powered by Google App Engine
This is Rietveld 408576698