implement `Invocation.typeArguments` in DDC

implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol, fixes #30223
* object members work for callable classes, fixes #30213
* some test fixes to work in strong mode
* a few other small cleanups (e.g. obsolete `dart.list` is removed)

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/04f3c8835f76ed09965ed2d68c242b09e779b549

[Jennifer Messerly, 2017-07-20 04:30:55]

Description was changed from

==========
implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol
* object members work for callable classes, fixes #30213
==========

to

==========
implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol
* object members work for callable classes, fixes #30213
* some test fixes to work in strong mode
==========

[Jennifer Messerly, 2017-07-20 04:32:35]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2017-07-20 04:33:40]

Description was changed from

==========
implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol
* object members work for callable classes, fixes #30213
* some test fixes to work in strong mode
==========

to

==========
implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol
* object members work for callable classes, fixes #30213
* some test fixes to work in strong mode
* a few other small cleanups (e.g. obsolete `dart.list` is removed)
==========

[Lasse Reichstein Nielsen, 2017-07-20 08:59:04]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2017-07-20 08:59:04]

https://codereview.chromium.org/2979353002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/js_array.dart (right):

https://codereview.chromium.org/2979353002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/js_array.dart:21: factory
JSArray.of(allocation) {
Drive-by-comment:
We are considering (strongly) to add a method called "of" to the Iterable class
(a type-filtering function like `Iterable<T> of<T>()` which will contain the
same elements as `iter.where((x)=>x is T)` but actually have type
`Iterable<T>`). 

I don't know if that will conflict with this constructor.

[vsm, 2017-07-20 15:07:12]

https://codereview.chromium.org/2979353002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2979353002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:284: $name,
$args, opts, {
What is opts here?  I only see two pos args on the InvocationImpl constructor
above.

[Jennifer Messerly, 2017-07-20 19:14:57]

thanks!

https://codereview.chromium.org/2979353002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2979353002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:284: $name,
$args, opts, {
On 2017/07/20 15:07:12, vsm wrote:
> What is opts here?  I only see two pos args on the InvocationImpl constructor
> above.

oh gosh! I didn't upload after fixing this. oops. Will do so.

https://codereview.chromium.org/2979353002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/js_array.dart (right):

https://codereview.chromium.org/2979353002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/js_array.dart:21: factory
JSArray.of(allocation) {
On 2017/07/20 08:59:04, Lasse Reichstein Nielsen wrote:
> Drive-by-comment:
> We are considering (strongly) to add a method called "of" to the Iterable
class
> (a type-filtering function like `Iterable<T> of<T>()` which will contain the
> same elements as `iter.where((x)=>x is T)` but actually have type
> `Iterable<T>`). 
> 
> I don't know if that will conflict with this constructor.

Oh that sounds lovely! Yes feel free to use `of` ... we are happy to change this
as needed :)

[Jennifer Messerly, 2017-07-20 19:50:50]

PTAL

[vsm, 2017-07-20 23:03:44]

lgtm

[Jennifer Messerly, 2017-07-21 20:29:06]

Description was changed from

==========
implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol
* object members work for callable classes, fixes #30213
* some test fixes to work in strong mode
* a few other small cleanups (e.g. obsolete `dart.list` is removed)
==========

to

==========
implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol, fixes #30223
* object members work for callable classes, fixes #30213
* some test fixes to work in strong mode
* a few other small cleanups (e.g. obsolete `dart.list` is removed)
==========

[Jennifer Messerly, 2017-07-21 22:51:26]

Description was changed from

==========
implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol, fixes #30223
* object members work for callable classes, fixes #30213
* some test fixes to work in strong mode
* a few other small cleanups (e.g. obsolete `dart.list` is removed)
==========

to

==========
implement `Invocation.typeArguments` in DDC

also fixes various bugs:
* setters now use the correct memberName symbol, fixes #30223
* object members work for callable classes, fixes #30213
* some test fixes to work in strong mode
* a few other small cleanups (e.g. obsolete `dart.list` is removed)

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/04f3c8835f76ed09965ed2d68c242b09e779b549
==========

[Jennifer Messerly, 2017-07-21 22:51:27]

Committed patchset #2 (id:10001) manually as
04f3c8835f76ed09965ed2d68c242b09e779b549 (presubmit successful).

[Leaf, 2017-07-26 00:46:30]

leafp@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2017-07-26 00:46:31]

https://codereview.chromium.org/2979353002/diff/10001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/js_array.dart (right):

https://codereview.chromium.org/2979353002/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_array.dart:24: return
dart.setType(allocation, JS('', 'JSArray'));
This change caused a dart._check to be added here, which seems to be causing a
massive performance regression.  I tested out changing just this line in google3
and saw a 5X or worse slowdown in test performance.  

I'll follow up with a CL to change this tomorrow.  I think we need to look at
alternatives to setType as well - still preliminary, but I think I'm seeing a
lot of slowdown for our pattern.

[Jennifer Messerly, 2017-07-26 01:23:01]

https://codereview.chromium.org/2979353002/diff/10001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/js_array.dart (right):

https://codereview.chromium.org/2979353002/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_array.dart:24: return
dart.setType(allocation, JS('', 'JSArray'));
On 2017/07/26 00:46:31, Leaf wrote:
> This change caused a dart._check to be added here, which seems to be causing a
> massive performance regression.  I tested out changing just this line in
google3
> and saw a 5X or worse slowdown in test performance.  
> 
> I'll follow up with a CL to change this tomorrow.  I think we need to look at
> alternatives to setType as well - still preliminary, but I think I'm seeing a
> lot of slowdown for our pattern.

oh shoot, I thought I'd fixed that before landing :(. I'll fix that real quick &
TBR to remove the cast

I can also try out some alternate patterns. Since JSArray is in the SDK and
cannot be subclassed, we have a lot of options in the implementation

[Jennifer Messerly, 2017-07-26 01:33:47]

https://codereview.chromium.org/2979353002/diff/10001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/js_array.dart (right):

https://codereview.chromium.org/2979353002/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_array.dart:24: return
dart.setType(allocation, JS('', 'JSArray'));
On 2017/07/26 01:23:00, Jennifer Messerly wrote:
> On 2017/07/26 00:46:31, Leaf wrote:
> > This change caused a dart._check to be added here, which seems to be causing
a
> > massive performance regression.  I tested out changing just this line in
> google3
> > and saw a 5X or worse slowdown in test performance.  
> > 
> > I'll follow up with a CL to change this tomorrow.  I think we need to look
at
> > alternatives to setType as well - still preliminary, but I think I'm seeing
a
> > lot of slowdown for our pattern.
> 
> oh shoot, I thought I'd fixed that before landing :(. I'll fix that real quick
&
> TBR to remove the cast
> 
> I can also try out some alternate patterns. Since JSArray is in the SDK and
> cannot be subclassed, we have a lot of options in the implementation

fixed in
https://codereview.chromium.org/2985063002/diff/1/pkg/dev_compiler/tool/input...